feature request: Add support for 'public' attribute on github pages configuration

[pkwarren]

We'd like to use the Github pages functionality of the terraform provider, however currently it doesn't support the github pages 'public' option: https://github.com/google/go-github/blob/178169fc04bc4a05ca48f98709cdd02ab5b556e3/github/repos_pages.go#L21

Terraform Version

v1.1.4

Affected Resource(s)

• github_repository

Terraform Configuration Files

resource "github_repository" "example" {
  name        = "example"
  description = "My awesome web page"
  private = true
  pages {
    source {
      branch = "main"
      path   = "/docs"
    }
    # TODO: Doesn't work
    public = false
  }
}

Expected Behavior

Should be able to configure 'public = false' to limit visibility of github pages.

Actual Behavior

Option not yet supported.

[pkwarren]

It looks like this will require fixes to upstream GitHub module: google/go-github#2261

[btkostner]

Looks like it has been included upstream and will be included in the next release

[btkostner]

go-github has released v43.0.0 which includes the fix here https://github.com/google/go-github/releases/tag/v43.0.0

[btkostner]

This issue should not yet be closed

[kfcampbell]

Oh I'm sorry! Thanks for catching this @btkostner.

[github-actions]

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

[btkostner]

Currently waiting for PR to merge

[ViacheslavKudinov]

We need this feature! 🙏🏻

[dweaver33]

[calebworks]

Any updates on this?

[ViacheslavKudinov]

Hello,
any updates or was it implemented ?

[Luis-3M]

What else is needed to make this feature available?

[btkostner]

It looks like the upstream lower level API library has this feature released now. Someone just needs to open the PR for it in the terraform provider.