-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add repository pages public attribute #1112
Conversation
Bump. This would be very helpful for our enterprise hosting static sites. As of right now, manually setting this field breaks any terraform runs after. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@btkostner sorry for the delay! Somehow I hadn't seen this yet. Would it be possible to alter the test(s) for this resource to include this new functionality? I'm thinking of some kind of addition of an appropriate test in this file.
} | ||
`, randomID) | ||
|
||
check := resource.ComposeTestCheckFunc( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding a test to capture this behavior! Is this check passing for you? When I run it, I'm getting Check failed: Check 1/1 error: github_repository.test: Attribute 'pages.0.public' expected "false", got "true"
.
It looks like we're only getting the "public" option, never setting it anywhere. Wouldn't we need some logic in the Create and Update functions to set this attribute?
👋 Hey Friends, this pull request has been automatically marked as |
This adds a
public
attribute to repository pages. This controls the accessibility of pages. See the GitHub API docs for more information. Here is the code in go-github. Closes #1045