Skip to content

[MAINT]: Update to go-github v79 w/projects #2822

@nickfloyd

Description

@nickfloyd

resolved by: #2898

Describe the need

go get github.com/google/go-github/v79@v79.0.0

Required changes

// OLD (v67/v68):
func resourceGithubRulesetObject(d *schema.ResourceData, org string) *github.Ruleset
func expandConditions(input []interface{}, org bool) *github.RulesetConditions

// NEW (v79):
func resourceGithubRulesetObject(d *schema.ResourceData, org string) *github.RepositoryRuleset  
func expandConditions(input []interface{}, org bool) *github.RepositoryRulesetConditions

Breaking change:
Ruleset method signature
CreateRuleset and UpdateRuleset now pass ruleset parameter by-value instead of by-reference.

Impact:
client.Repositories.CreateRuleset(ctx, owner, repoName, rulesetReq)
client.Repositories.UpdateRulesetNoBypassActor(ctx, owner, repoName, rulesetID, rulesetReq)
client.Organizations.CreateOrganizationRuleset(ctx, owner, rulesetReq)
client.Organizations.UpdateOrganizationRuleset(ctx, owner, rulesetID, rulesetReq)

We need to update the method calls to pass by value instead of by reference (remove & operators if any).

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: TriageThis is being looked at and prioritizedType: MaintenanceAny dependency, housekeeping, and clean up Issue or PR

    Type

    Projects

    Status

    In Progress

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions