Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github_repository should have optional id field #744

Closed
threeseed opened this issue Mar 29, 2021 · 3 comments
Closed

github_repository should have optional id field #744

threeseed opened this issue Mar 29, 2021 · 3 comments
Labels
Good first issue Good for newcomers r/repository Status: Stale Used by stalebot to clean house Type: Feature New feature or request

Comments

@threeseed
Copy link
Contributor

threeseed commented Mar 29, 2021

Affected Resource(s)

  • github_repository

Feature Request

It is common to want to rename Github repositories but doing so using this provider can often lead to data loss for associated data e.g. issues, projects, labels.

Having a user specify an optional id field for each repository (which could be stored as a Repository Secret e.g. Terraform ID) would ensure that renames and reorders (when you have a list of repositories) would not cause data loss.

Alternatively if the ID/NodeID attributes in the gitHub-go library can be used to track the repositories instead of the name.

References

@jcudit jcudit added Type: Feature New feature or request r/repository labels Apr 6, 2021
@jcudit jcudit added this to the v4.10.0 milestone May 11, 2021
@jcudit jcudit added the Good first issue Good for newcomers label May 13, 2021
@jcudit jcudit removed this from the v4.10.0 milestone May 21, 2021
@github-actions
Copy link

github-actions bot commented Dec 3, 2022

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Dec 3, 2022
@shoddyguard
Copy link

I think this may no longer be needed due to #699 having been shipped?

@kfcampbell
Copy link
Member

@shoddyguard you're right, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers r/repository Status: Stale Used by stalebot to clean house Type: Feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants