Do not destroy the repository when you change the repository name

[k24dizzle]

Inspired by the discussion in here: #616, the change for this was easier than I expected. I just made it so that changing the name field wouldn't force a new resource.

I tested this change locally using the following terraform config:

resource "github_repository" "test" {
  name        = "renamerepo"
  description = "testing renaming a repo"
  auto_init   = true
}

After planning and applying the config above, I went ahead and changed the config to:

resource "github_repository" "test" {
  name        = "renamerepo2"
  description = "testing renaming a repo"
  auto_init   = true
}

The following gist contains the resulting plan and apply of the provider before and after my changes.

I also went ahead and added a unit test for this:

    --- PASS: TestAccGithubRepositories/updates_a_repositories_name_without_error (10.03s)
        --- SKIP: TestAccGithubRepositories/updates_a_repositories_name_without_error/with_an_anonymous_account (0.00s)
        --- SKIP: TestAccGithubRepositories/updates_a_repositories_name_without_error/with_an_individual_account (0.00s)
        --- PASS: TestAccGithubRepositories/updates_a_repositories_name_without_error/with_an_organization_account (10.03s)

[k24dizzle]

Is there a way to add a check in here that the existing resource wasn't destroyed/a new resource wasn't created?

[jcudit]

We manually verified that the rename operation did not cause a repository deletion by viewing audit logs for our test org:

[jcudit]

Given this added test and some manual verification, this safe to be released for further testing in the community.

[jcudit]

We manually verified that the rename operation did not cause a repository deletion by viewing audit logs for our test org: