-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use the appropriate ID when trying to import github_team_members
objects
#1074
Conversation
…s` objects When importing a `github_team_member`, the import command passes in team ID as the "Id", not the "team_id" captured in the state for existing resources, and this empty string is causing the import step to fail when parsing as a number. Should fix integrations#608, as I hit the same error.
I tested this by following these notes and running |
Good catch! I actually had also just dug in and realized this was the problem. The generic error actually had me all tripped up in thinking it was the schema validation at first. I think that old issue from 2020 is something else, but this definitely solves a very active problem in the recent release. My only Q (and this comes from a place of ignorance w/ the codebase): Do we need to repeat the pattern from
|
I believe line 85 using the split on |
@kfcampbell any chance this could get bumped up in priority? It effectively makes the newest resource added unusable until this is merged. If there's another individual or group you'd like tagged, lemme know! |
For anyone blocked by this, you can take the patch, follow these steps, and run the imports. Since this only breaks imports, the rest of your workflow can remain the same after your import step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! I'll get this released shortly.
…s` objects (integrations#1074) When importing a `github_team_member`, the import command passes in team ID as the "Id", not the "team_id" captured in the state for existing resources, and this empty string is causing the import step to fail when parsing as a number. Should fix integrations#608, as I hit the same error.
…s` objects (integrations#1074) When importing a `github_team_member`, the import command passes in team ID as the "Id", not the "team_id" captured in the state for existing resources, and this empty string is causing the import step to fail when parsing as a number. Should fix integrations#608, as I hit the same error.
When importing a
github_team_member
, the import command passes in the data as the"Id", not the "team_id", causing the import step to fail when parsing an empty string
as a number. Should fix #608, as I hit the same error.