Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(team_repository): suppress team repository etag diffs #1303

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rudineirk
Copy link

same as: #909

@rudineirk rudineirk force-pushed the fix/team-repository-etag branch from 98aa582 to ca618ad Compare September 26, 2022 18:01
@rudineirk rudineirk marked this pull request as ready for review September 26, 2022 18:02
@rudineirk rudineirk force-pushed the fix/team-repository-etag branch from ca618ad to 32d3c7a Compare September 26, 2022 18:36
@rudineirk rudineirk changed the title fix(team_repository): fix team repository etag diffs fix(team_repository): suppress team repository etag diffs Sep 26, 2022
@rudineirk
Copy link
Author

Ignore this PR, was using an outdated version (4.3), in the latest version it's working as expected

@rudineirk rudineirk closed this Sep 26, 2022
@rudineirk rudineirk reopened this Sep 26, 2022
@rudineirk
Copy link
Author

It still happens on 5.3, my mistake

@johnrengelman
Copy link

Can this simple change please get merged and released? Its the same issue seen in other resources.

@kfcampbell
Copy link
Member

@johnrengelman I'm a bit conflicted due to the issues reported on this PR. Do you have thoughts on that?

Copy link

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Nov 15, 2023
@rmartine-ias
Copy link

rmartine-ias commented Nov 17, 2023

This is still an issue. Probably not the right approach, can etag be removed altogether?

@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Nov 18, 2023
Copy link

👋 Hey Friends, this pull request has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Aug 14, 2024
@rmartine-ias
Copy link

Not stale.
See also: https://nostalebots.xyz/

@github-actions github-actions bot removed the Status: Stale Used by stalebot to clean house label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants