Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak error message in provider_utils.go #1395

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

kfcampbell
Copy link
Member

This resolves a small inaccuracy in an error message I ran into while debugging earlier in the week.


Behavior

Before the change?

Regardless of whether the error was with the GITHUB_OWNER or GITHUB_ORGANIZATION, the error message reported the issue was with the GITHUB_OWNER environment variable.

After the change?

The error message reads fmt.Errorf("configured owner %q is a user, not an organization", meta.(*Owner).name).

Other information

Similar to #1394, this is a small thing that's been bothering me.


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features) (N/A)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@kfcampbell kfcampbell added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Nov 29, 2022
@kfcampbell kfcampbell requested a review from nickfloyd November 29, 2022 23:01
@kfcampbell kfcampbell merged commit 90aa230 into integrations:main Dec 2, 2022
@kfcampbell kfcampbell deleted the error-message-tweak branch December 2, 2022 00:32
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
avidspartan1 pushed a commit to avidspartan1/terraform-provider-github that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant