Fixed repo envs so terraform will add back in deployment branch protection if it is removed manually from GitHub #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent branch protection if it is removed manually from GitHub
kfcampbell
approved these changes
Oct 26, 2023
scott-doyland-burrows
deleted the
fix/environment-deployment-branch-policy-no-diff
branch
avidspartan1
pushed a commit
to avidspartan1/terraform-provider-github
that referenced
this pull request
Feb 5, 2024
…ent branch protection if it is removed manually from GitHub (integrations#1981) Co-authored-by: Keegan Campbell <me@kfcampbell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1955
Before the change?
Manually removing an environment's deployment branch protection in GitHub (setting it back to no restriction) would not show a diff when terraform was applied. This meant terraform and GitHub were out of line.
After the change?
Terraform brings the environment's deployment branch protection back inline with terraform.
The tests pass - albeit they don't give full coverage, and never did (I have not updated the tests). They need some extra work to make them better.
There are also two minor changes (as vscode was complaining) which just set lowercase for an error message and remove a full stop for another error message in two unrelated files.
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!