Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return the error when deleting a file #2465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return the error when deleting a file #2465

wants to merge 1 commit into from

Conversation

frankywahl
Copy link
Contributor

There is currently an issue when destroying the github_repository_file resource. If the action fails because of permissions, or because there is a protected branch, or any of the above, the error gets silenced.

Resolves #2464

Before the change?

  • Delete a github_repository_file would be successful even if the API call failed.

After the change?

  • A failed API call will not mark the apply as being successful

Does this introduce a breaking change?

  • No (unless people are expecting that bad behavior).

@frankywahl
Return the error when deleting a file
9ebcefa 
There is currently an issue when destroying the github_repository_file
resource. If the action fails because of permissions, or because there
is a protected branch, or any of the above, the error gets silenced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Deleting github_repository_file resource might not remove the file
1 participant
@frankywahl