Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/repository*: support individual user for resource management (limited to authenticated user) #465

Merged
merged 5 commits into from
Jun 19, 2020

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented May 17, 2020

Closes #45
Relates #371

  • Changes include:
    • builds off of github/provider: introduce owner  #464
    • support for lifecycle management of repo-related resources with authenticated user
      • renaming of org(Name) -> owner and removal of checkOrganization in CRUD methods

Output of acceptance tests (as organization):
GithubRepository:

--- PASS: TestAccGithubRepository_hasProjects (6.15s)
--- PASS: TestAccGithubRepository_archive (7.63s)
--- PASS: TestAccGithubRepository_createFromTemplate (7.69s)
--- PASS: TestAccGithubRepository_basic (12.22s)
--- PASS: TestAccGithubRepository_defaultBranch (13.08s)
--- PASS: TestAccGithubRepository_templates (16.71s)
--- PASS: TestAccGithubRepository_topics (19.53s)
--- PASS: TestAccGithubRepository_archiveUpdate (22.18s)
--- PASS: TestAccGithubRepository_autoInitForceNew (27.79s)

GithubRepositoryDeployKey:

--- PASS: TestAccGithubRepositoryDeployKey_basic (11.11s)

GithubRepositoryProject:

--- PASS: TestAccGithubRepositoryProject_basic (10.52s)

GithubRepositoryWebhook:

--- PASS: TestAccGithubRepositoryWebhook_secret (12.16s)
--- PASS: TestAccGithubRepositoryWebhook_basic (16.51s)

GithubRepositoryDataSource:

--- PASS: TestAccGithubRepositoryDataSource_name_noMatchReturnsError (0.35s)
--- PASS: TestAccGithubRepositoryDataSource_fullName_noMatchReturnsError (0.38s)
--- PASS: TestAccGithubRepositoryDataSource_fullName_existing (1.88s)
--- PASS: TestAccGithubRepositoryDataSource_name_existing (2.15s)
--- PASS: TestAccGithubRepositoryDeployKey_basic (11.01s)

GithubRepositoriesDataSource:

--- PASS: TestAccGithubRepositoriesDataSource_noMatch (2.07s)
--- PASS: TestAccGithubRepositoriesDataSource_basic (3.31s)
--- PASS: TestAccGithubRepositoriesDataSource_Sort (40.60s)

Output of acceptance tests (as user):
GithubRepository:

--- PASS: TestAccGithubRepository_hasProjects (5.20s)
--- PASS: TestAccGithubRepository_createFromTemplate (6.25s)
--- PASS: TestAccGithubRepository_basic (9.60s)
--- PASS: TestAccGithubRepository_templates (10.88s)
--- PASS: TestAccGithubRepository_archiveUpdate (11.04s)
--- PASS: TestAccGithubRepository_archive (11.11s)
--- PASS: TestAccGithubRepository_defaultBranch (11.17s)
--- PASS: TestAccGithubRepository_topics (17.68s)
--- SKIP: TestAccGithubRepository_autoInitForceNew (0.23s)

GithubRepositoryDeployKey:

--- PASS: TestAccGithubRepositoryDeployKey_basic (10.57s)

GithubRepositoryProject:

--- PASS: TestAccGithubRepositoryProject_basic (9.50s)

GithubRepositoryWebhook:

--- PASS: TestAccGithubRepositoryWebhook_secret (14.97s)
--- PASS: TestAccGithubRepositoryWebhook_basic (19.19s)

GithubRepositoryDataSource:

--- PASS: TestAccGithubRepositoryDataSource_name_noMatchReturnsError (0.33s)
--- PASS: TestAccGithubRepositoryDataSource_fullName_noMatchReturnsError (0.62s)
--- PASS: TestAccGithubRepositoryDataSource_name_existing (1.42s)
--- PASS: TestAccGithubRepositoryDataSource_fullName_existing (1.43s)
--- PASS: TestAccGithubRepositoryDeployKey_basic (10.18s)

GithubRepositoriesDataSource:

--- PASS: TestAccGithubRepositoriesDataSource_noMatch (1.10s)
--- PASS: TestAccGithubRepositoriesDataSource_basic (2.07s)
--- PASS: TestAccGithubRepositoriesDataSource_Sort (15.34s)

@ghost ghost added the size/M label May 17, 2020
@anGie44 anGie44 marked this pull request as ready for review May 17, 2020 19:49
@jcudit jcudit added this to the v2.9.0 milestone Jun 3, 2020
@ghost ghost added size/L and removed size/M labels Jun 9, 2020
@anGie44 anGie44 force-pushed the ap_support_individual_repos branch from 24909f2 to 97d0d4a Compare June 10, 2020 04:48
Copy link
Contributor

@jcudit jcudit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anGie44 my local testing has gone well with this branch, but seem to have gotten this PR into a broken state. Can you force push what you have locally so we can merge? My aim is to follow up with acceptance test fixes in separate PRs.

@anGie44 anGie44 force-pushed the ap_support_individual_repos branch from 8719715 to eea7c41 Compare June 17, 2020 18:04
@ghost ghost added size/S and removed size/XXL labels Jun 18, 2020
@anGie44 anGie44 closed this Jun 18, 2020
@anGie44 anGie44 force-pushed the ap_support_individual_repos branch from a6d3427 to 9dd0b20 Compare June 18, 2020 01:16
@ghost ghost added size/XS and removed size/S labels Jun 18, 2020
@anGie44 anGie44 reopened this Jun 18, 2020
@ghost ghost added size/S and removed size/XS labels Jun 18, 2020
@anGie44 anGie44 force-pushed the ap_support_individual_repos branch from a6d3427 to da4fc18 Compare June 18, 2020 01:25
@ghost ghost added size/L and removed size/S labels Jun 18, 2020
@ghost ghost removed the size/L label Jun 18, 2020
@ghost ghost added the size/XL label Jun 18, 2020
@anGie44 anGie44 changed the title github/repository: support individual repo creation (limited to authenticated user) github/repository*: support invidual user for resource management (limited to authenticated user) Jun 18, 2020
@anGie44 anGie44 changed the title github/repository*: support invidual user for resource management (limited to authenticated user) github/repository*: support individual user for resource management (limited to authenticated user) Jun 18, 2020
@anGie44 anGie44 requested a review from jcudit June 18, 2020 04:16
@ghost ghost added the Type: Documentation Improvements or additions to documentation label Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support personal repositories not only GitHub organization
2 participants