Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove skip-ias-remnants from CI and readme #183

Merged
merged 1 commit into from
Jul 28, 2023
Merged

remove skip-ias-remnants from CI and readme #183

merged 1 commit into from
Jul 28, 2023

Conversation

clangenb
Copy link
Collaborator

No description provided.

clangenb
clangenb commented Jul 28, 2023
View reviewed changes
.github/workflows/ci.yml
@@ -163,64 +163,6 @@ jobs:
env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

build_dev_ias_binaries:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now the same as the regular build_dev_ias_binaries

@clangenb clangenb requested review from mosonyi, OverOrion and brenzi and removed request for mosonyi and OverOrion July 28, 2023 09:21
OverOrion
OverOrion approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with a quick grep and there is not any IAS leftover, so LGTM!

mosonyi
mosonyi approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@mosonyi mosonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@clangenb clangenb merged commit b2392f9 into master Jul 28, 2023
12 checks passed
@clangenb clangenb mentioned this pull request Aug 14, 2023
Merged
@clangenb clangenb deleted the cl/remove-skip-ias-remnants branch August 28, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosonyi mosonyi mosonyi approved these changes

@OverOrion OverOrion OverOrion approved these changes

@brenzi brenzi Awaiting requested review from brenzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clangenb @mosonyi @OverOrion