Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitelist of trusted exchange rate oracles #24

Merged
merged 6 commits into from
Dec 8, 2021

Conversation

echevrier
Copy link
Contributor

Update of exchange rate can only be done by a trusted oracle

echevrier added 3 commits December 1, 2021 10:23
… list, to clear the whitelist.

Add "pseudo" weights for the new calls
 clean unit test,
 update benchmarking
@echevrier echevrier requested review from brenzi and clangenb December 1, 2021 15:39
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but looks good.

I like the cleanly written tests!

teeracle/src/lib.rs Outdated Show resolved Hide resolved
teeracle/src/lib.rs Outdated Show resolved Hide resolved
teeracle/src/lib.rs Outdated Show resolved Hide resolved
teeracle/src/tests.rs Outdated Show resolved Hide resolved
@echevrier echevrier requested a review from clangenb December 2, 2021 09:53
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice and clean.

teeracle/src/lib.rs Outdated Show resolved Hide resolved
teeracle/src/lib.rs Outdated Show resolved Hide resolved
teeracle/src/lib.rs Outdated Show resolved Hide resolved
teeracle/src/lib.rs Outdated Show resolved Hide resolved
teeracle/src/mock.rs Outdated Show resolved Hide resolved
teeracle/src/lib.rs Outdated Show resolved Hide resolved
@brenzi brenzi merged commit 6471e27 into master Dec 8, 2021
@echevrier echevrier deleted the ec_whitelist_oracles_#17 branch April 19, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

teeracle must maintain a whitelist of trusted exchange rate oracle MRENCLAVEs
3 participants