Add DCAP and pallet_xcm benchmarks #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
clangenb
commented
May 17, 2023
•
clangenb
commented
- Re-run the pallet-teerex benchmarks
- added the pallet-xcm benchmarks, closes add benchmarked xcm weights #207.
brenzi
reviewed
Jan 30, 2024
| // Measured: `0` | ||
| // Estimated: `0` | ||
| // Minimum execution time: 18_446_744_073_709_551 nanoseconds. | ||
| Weight::from_ref_time(18_446_744_073_709_551_000) |
There was a problem hiding this comment.
this shouldn't have slipped our reviews. very funny execution time indeed. this most likely breaks receiving XCM messages and makes everything overweight. CC @clangenb
There was a problem hiding this comment.
Hmm, interesting. Funnily, moonbeam has the same weird weight for teleport assets, but their execute() weight seems fine: https://github.com/moonbeam-foundation/moonbeam/blob/d4fdae0cf795ebb48b7a2a9c2167c7dae56e782f/runtime/common/src/weights/pallet_xcm.rs#L75
There was a problem hiding this comment.
fixing this doesn't solve our problem, unfortunately. but needs fixing anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.