Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ab/fix weight bound #257

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Ab/fix weight bound #257

merged 7 commits into from
Jan 31, 2024

Conversation

brenzi
Copy link
Collaborator

@brenzi brenzi commented Jan 30, 2024 •
edited
Loading

closes #256

@clangenb
Copy link
Contributor

clangenb commented Jan 30, 2024 •
edited
Loading

We probably have to look with more logs into our barrier and see which should_execute of the barrier tuple records an overweight: https://github.com/paritytech/polkadot-sdk/blob/a190e0e9253562fdca9c1b6e9541a7ea0a50c018/polkadot/xcm/xcm-builder/src/barriers.rs#L36C5-L36C19

@brenzi brenzi marked this pull request as ready for review January 31, 2024 11:58
@brenzi brenzi requested a review from clangenb January 31, 2024 11:58
@brenzi brenzi merged commit 792f591 into master Jan 31, 2024
20 checks passed
clangenb
clangenb reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, minimal fix. This is how I like it.

polkadot-parachains/integritee-runtime/src/xcm_config.rs
@@ -76,6 +76,7 @@ parameter_types! {

pub SelfReserve: MultiLocation = MultiLocation {
parents:0,
//todo: why not `interior: Here` ?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea. I think I copied this from elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XCM token transfer to Integritee chain fails with WeightLimitReached
2 participants
@brenzi @clangenb