Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement next_key in SGX sp-io #1030

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Implement next_key in SGX sp-io #1030

merged 2 commits into from
Oct 3, 2022

Conversation

Kailai-Wang
Copy link
Contributor

This PR tries to add a basic implementation of next_key in SGX sp-io which would have caused problems when doing iterator-based queries. Also see litentry/tee-worker#84

In my (integration) tests with sgx runtime, iter_values and iter_prefix both work now.

As it's read-only I believe no change to state_diff is needed.
It's my first PR so please let me know if anything is inappropriate, thanks!

@haerdib haerdib added A0-core Affects a core part B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing labels Oct 3, 2022
haerdib
haerdib reviewed Oct 3, 2022
View reviewed changes
Copy link
Contributor

@haerdib haerdib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark from my side. Other than that, it looks very good. Thank you very much!

core-primitives/substrate-sgx/externalities/src/lib.rs Outdated Show resolved Hide resolved
@haerdib haerdib requested a review from murerfel October 3, 2022 06:30
murerfel
murerfel approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@murerfel murerfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution! 🙏

@haerdib haerdib merged commit df56d2c into integritee-network:master Oct 3, 2022
@Kailai-Wang Kailai-Wang deleted the next-key-impl-in-sgx-sp-io branch October 3, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murerfel murerfel murerfel approved these changes

@haerdib haerdib haerdib approved these changes

Assignees
No one assigned
Labels
A0-core Affects a core part B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kailai-Wang @murerfel @haerdib