Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STF primitives extraction #1112

Merged
merged 13 commits into from
Dec 8, 2022
Merged

STF primitives extraction #1112

merged 13 commits into from
Dec 8, 2022

Conversation

OverOrion
Copy link
Contributor

@OverOrion OverOrion commented Nov 27, 2022 •
edited
Loading

I believe I extracted what I could, the other modules can not be easily extracted as of now.

Fixes #296

@OverOrion OverOrion force-pushed the szp/stf-primitives-extraction_one_big branch 2 times, most recently from 4ac833d to 4441b0f Compare December 1, 2022 17:20
@OverOrion OverOrion added A6-evm Smart Contract ETH pallet A0-core Affects a core part A1-cli Affects cli functionalites A2-applibs Affects app-libs, i.e. runtime or stf B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E3-hardmerge PR introduces a lot changes in a lot of files. Requires some effort to merge or rebase to. E5-publicapi PR breaks public API E8-breakseverything PR with major changes in the code base, breaks at least one major functionality labels Dec 1, 2022
@OverOrion OverOrion force-pushed the szp/stf-primitives-extraction_one_big branch from 4441b0f to c3333fb Compare December 1, 2022 18:21
@OverOrion OverOrion force-pushed the szp/stf-primitives-extraction_one_big branch 2 times, most recently from c944373 to 762f9da Compare December 6, 2022 06:25
@OverOrion OverOrion force-pushed the szp/stf-primitives-extraction_one_big branch from 762f9da to 57e16ac Compare December 7, 2022 13:40
@OverOrion OverOrion added E0-breaksnothing and removed E3-hardmerge PR introduces a lot changes in a lot of files. Requires some effort to merge or rebase to. E5-publicapi PR breaks public API E8-breakseverything PR with major changes in the code base, breaks at least one major functionality A6-evm Smart Contract ETH pallet labels Dec 7, 2022
@OverOrion OverOrion marked this pull request as ready for review December 7, 2022 18:21
@OverOrion OverOrion changed the title [WIP] STF primitives extraction STF primitives extraction Dec 7, 2022
clangenb
clangenb reviewed Dec 8, 2022
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you simplified it a lot. :D

Looks good, I only have one question.

core-primitives/stf-primitives/Cargo.toml Outdated
Comment on lines 21 to 23
sgx = [
"sgx_tstd",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this crate does not need the sgx feature

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, Box is available in alloc 🚀

clangenb
clangenb approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaay finally! :)

@clangenb clangenb merged commit 1d0cc6c into integritee-network:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

@coax1d coax1d Awaiting requested review from coax1d

Assignees
No one assigned
Labels
A0-core Affects a core part A1-cli Affects cli functionalites A2-applibs Affects app-libs, i.e. runtime or stf B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extract primitives from STF crate
2 participants
@OverOrion @clangenb