Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[local-setup] ignore if key.txt and spid.txt are not found #1130

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

clangenb
Copy link
Contributor

@clangenb clangenb commented Dec 20, 2022

We recently removed the condition that those files need to be present in the rust code because they are not needed if we don't perform the remote attestation: #1116

However, this part was missed in the local setup. This fixes it, and simply prints a small warning that remote attestation is not possible when those files are not present.

@clangenb clangenb requested review from coax1d and OverOrion December 20, 2022 14:50
@clangenb clangenb added B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing A7-somethingelse labels Dec 20, 2022
Copy link
Contributor

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thank you for it!

local-setup/py/helpers.py Outdated Show resolved Hide resolved
Co-authored-by: Szilárd Parrag <szilard.parrag@gmail.com>
@clangenb clangenb requested a review from OverOrion December 20, 2022 15:30
Copy link
Contributor

@OverOrion OverOrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍝

@clangenb clangenb merged commit 1ba5a8f into master Dec 21, 2022
@clangenb clangenb deleted the cl/local-setup branch January 12, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A7-somethingelse B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants