Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] CI: enable EPID RA #1269

Closed
wants to merge 6 commits into from
Closed

[WIP] CI: enable EPID RA #1269

wants to merge 6 commits into from

Conversation

OverOrion
Copy link
Contributor

This PR is basically the same as #1224 but the target branch is different.

Draft until #1222 gets merged.

@OverOrion OverOrion mentioned this pull request Apr 3, 2023
Closed
3 tasks
@OverOrion
Copy link
Contributor Author

OverOrion commented Apr 19, 2023 •
edited
Loading

The tests are failing because GHA secrets are not available in forked repositories.

With the exception of GITHUB_TOKEN, secrets are not passed to the runner when a workflow is triggered from a forked repository.

https://docs.github.com/en/actions/security-guides/encrypted-secrets#using-encrypted-secrets-in-a-workflow

Switching to pull_request_target would solve it, but it has some security implications, which we should discuss first.
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

@OverOrion
Copy link
Contributor Author

Superseded by #1286

@OverOrion OverOrion closed this Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@OverOrion