move sidechain_importBlock rpc method to trusted rpc #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kziemianek
commented
Jul 23, 2024
clangenb
approved these changes
Jul 24, 2024
Comment on lines
-172
to
+164
| let worker_api_direct = DirectWorkerApi::new(enclave_url.clone().into()); | ||
| match worker_api_direct.get_untrusted_worker_url() { | ||
| Ok(untrusted_worker_url) => { | ||
| peer_urls.push(untrusted_worker_url); | ||
| }, | ||
| Err(e) => { | ||
| error!( | ||
| "Failed to get untrusted worker url (enclave: {}): {:?}", | ||
| enclave_url, e | ||
| ); | ||
| }, | ||
| } | ||
| peer_urls.push(enclave_url.into()); |
There was a problem hiding this comment.
Just commenting for the records, we change the to enclave_url because the server is now running on the trusted side.
Comment on lines
+111
to
+112
| let direct_client = DirectWorkerApi::new(url.clone()); | ||
| if let Err(e) = direct_client.import_sidechain_blocks(encoded_blocks_cloned) { |
There was a problem hiding this comment.
Nice code quality improvement :)
Comment on lines
39
to
41
| let fetch_sidechain_blocks_module = BlockFetchServerModuleBuilder::new(sidechain_block_fetcher) | ||
| .build() | ||
| .map_err(|e| CallError::Failed(e.to_string().into()))?; // `to_string` necessary due to no all errors implementing Send + Sync. |
There was a problem hiding this comment.
hmmm, I guess the sidechain block fetcher should also be on the trusted side eventually.
clangenb
added
A3-sidechain
B1-releasenotes
C1-low 📌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to move
sidechain_importBlockfrom untrusted rpc endpoint to trusted. By doing so, there is no need to query for untrusted url anymore during peers update. It also:rpc_methodstrusted json-rpc method