Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return total issuance metric as decimal value #1632

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

brenzi
Copy link
Collaborator

@brenzi brenzi commented Nov 4, 2024

it is a bit annoying to handle mixed denominations in grafana. better to use decimal values for balances strictly

I wasn't sure if the Stf Getter is the best place to implement the GetDecimals trait, but it certainly went lean and smooth and it's not completely unrelated

testing in local setup

metric: integritee_worker_enclave_stf_runtime_total_issuance 10003.000000001

./integritee-cli trusted --mrenclave Aocz5CscDUYtJSfToSPMkDXBTJCtn3Ys3BSJYbnQKshR get-total-issuance                                       
10003000000001000   
# 10_003_000_000_001_000

@brenzi brenzi requested a review from clangenb November 4, 2024 17:15
@brenzi brenzi added A2-applibs Affects app-libs, i.e. runtime or stf B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing labels Nov 4, 2024
Copy link
Contributor

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny nitpick. Looks good to me otherwise.

core-primitives/stf-executor/src/executor.rs Show resolved Hide resolved
@brenzi brenzi merged commit 5229af7 into master Nov 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2-applibs Affects app-libs, i.e. runtime or stf B1-releasenotes C1-low 📌 Does not elevate a release containing this beyond "low priority" E0-breaksnothing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants