Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add transpose_value_cache for NPU benchmark #12092

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

ch1y0q
Copy link
Contributor

@ch1y0q ch1y0q commented Sep 19, 2024

Description

1. Why the change?

2. User API changes

3. Summary of the change

4. How to test?

  • N/A
  • Unit test: Please manually trigger the PR Validation here by inputting the PR number (e.g., 1234). And paste your action link here once it has been successfully finished.
  • Application test
  • Document test
  • ...

5. New dependencies

  • New Python dependencies
    - Dependency1
    - Dependency2
    - ...
  • New Java/Scala dependencies and their license
    - Dependency1 and license1
    - Dependency2 and license2
    - ...

@rnwang04 rnwang04 self-requested a review September 19, 2024 07:07
@rnwang04
Copy link
Contributor

Please also update config.yaml

@@ -41,3 +41,4 @@ streaming: False # whether output in streaming way (only available now for gpu w
optimize_model: False # whether apply further optimization on NPU (only available now for transformers_int4_npu_win test_api)
use_fp16_torch_dtype: True # whether use fp16 for non-linear layer (only available now for "pipeline_parallel_gpu" test_api)
task: 'continuation' # task can be 'continuation', 'QA' and 'summarize'
transpose_value_cache: True
Copy link
Contributor

@rnwang04 rnwang04 Sep 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# whether apply transposed v_cache optimization on NPU (only available now for transformers_int4_npu_win test_api)

@rnwang04 rnwang04 changed the title add transpose_value_cache add transpose_value_cache for NPU benchmark Sep 19, 2024
@rnwang04
Copy link
Contributor

Please confirm these cases : True / False / no setting in config.yaml if work normally.

Copy link
Contributor

@rnwang04 rnwang04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rnwang04 rnwang04 merged commit 9650bf6 into intel-analytics:main Sep 19, 2024
1 check passed
@ch1y0q ch1y0q deleted the npu-transpose-v-cache branch September 20, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants