Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3: Timeout modifies only the connection timeout #270

Closed
zoran-rajic opened this issue Apr 30, 2015 · 4 comments
Closed

S3: Timeout modifies only the connection timeout #270

zoran-rajic opened this issue Apr 30, 2015 · 4 comments

Comments

@zoran-rajic
Copy link
Contributor

Specifying the timeout value in the S3 workload, ie:

  <storage type="s3" config="timeout=600000;accesskey=AKIA..."/>

.. modifies only the socket connection timeout.

Expectation:

  • the given timeout should modify both socket-connection, and socket-inactivity timeouts.
@ywang19
Copy link
Contributor

ywang19 commented Apr 30, 2015

Yes, it’s an expected enhancement. So far only one timeout value, from my perspective, more tcp settings could be added as options beside those two timeouts.

-yaguang

From: Zoran Rajic [mailto:notifications@github.com]
Sent: Thursday, April 30, 2015 3:55 PM
To: intel-cloud/cosbench
Subject: [cosbench] S3: Timeout modifies only the connection timeout (#270)

Specifying the timeout value in the S3 workload, ie:

.. modifies only the socket connection timeout.

Expectation:

  • the given timeout should modify both socket-connection, and socket-inactivity timeouts.


Reply to this email directly or view it on GitHubhttps://github.com//issues/270.

zoran-rajic added a commit to zoran-rajic/cosbench that referenced this issue Apr 30, 2015
@zoran-rajic
Copy link
Contributor Author

Hello Yaguang,

It's good to know you were preparing the same enhancement. Apropos, the fix is trivial (see zoran-rajic@8f1de4c).

Thanks,
Zoran

@ywang19
Copy link
Contributor

ywang19 commented Apr 30, 2015

Hi Zoran,

Could you pull your fix to upstream?

-yaguang

From: Zoran Rajic [mailto:notifications@github.com]
Sent: Thursday, April 30, 2015 4:18 PM
To: intel-cloud/cosbench
Cc: Wang, Yaguang
Subject: Re: [cosbench] S3: Timeout modifies only the connection timeout (#270)

Hello Yaguang,

It's good to know you were preparing the same enhancement. Apropos, the fix is trivial (see zoran-rajic@8f1de4chttps://github.com/zoran-rajic/cosbench/commit/8f1de4c2b8c0f5aa4cf695a086d5bb66fec32659).

Thanks,
Zoran


Reply to this email directly or view it on GitHubhttps://github.com//issues/270#issuecomment-97703576.

@zoran-rajic
Copy link
Contributor Author

Hi Yaguang,

Created pull request @ #271

Thanks,
Zoran

ywang19 pushed a commit that referenced this issue Apr 30, 2015
Fix #270: S3 timeout parameter modifies both connection and inactivity timeouts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants