Skip to content

Commit

Permalink
[media] tc358743: Setup default mbus_fmt before registering
Browse files Browse the repository at this point in the history
Previously the mbus_fmt_code was set after the device was
registered. If a connected sub-device called tc358743_get_fmt
prior to that point it would get an invalid code back.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
  • Loading branch information
6by9 authored and mchehab committed Jun 7, 2017
1 parent 3cb0fe6 commit 2da2391
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/media/i2c/tc358743.c
Original file line number Diff line number Diff line change
Expand Up @@ -1910,6 +1910,8 @@ static int tc358743_probe(struct i2c_client *client,
if (err < 0)
goto err_hdl;

state->mbus_fmt_code = MEDIA_BUS_FMT_RGB888_1X24;

sd->dev = &client->dev;
err = v4l2_async_register_subdev(sd);
if (err < 0)
Expand All @@ -1924,7 +1926,6 @@ static int tc358743_probe(struct i2c_client *client,

tc358743_s_dv_timings(sd, &default_timing);

state->mbus_fmt_code = MEDIA_BUS_FMT_RGB888_1X24;
tc358743_set_csi_color_space(sd);

tc358743_init_interrupts(sd);
Expand Down

0 comments on commit 2da2391

Please sign in to comment.