Skip to content

Commit

Permalink
wifi: wl1251: Use IRQF_NO_AUTOEN flag in request_irq()
Browse files Browse the repository at this point in the history
As commit cbe16f3 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
said, the code below is subobtimal. IRQF_NO_AUTOEN flag can be used by
drivers to request_irq(). It prevents the automatic enabling of the
requested interrupt in the same safe way. With that the usage can be
simplified and corrected.

	irq_set_status_flags(irq, IRQ_NOAUTOEN);
	request_irq(dev, irq...);

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20240910124314.698896-4-ruanjinjie@huawei.com
  • Loading branch information
Jinjie Ruan authored and Kalle Valo committed Sep 18, 2024
1 parent 9a98dd4 commit 5a4d42c
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/wireless/ti/wl1251/sdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,8 @@ static int wl1251_sdio_probe(struct sdio_func *func,
}

if (wl->irq) {
irq_set_status_flags(wl->irq, IRQ_NOAUTOEN);
ret = request_irq(wl->irq, wl1251_line_irq, 0, "wl1251", wl);
ret = request_irq(wl->irq, wl1251_line_irq, IRQF_NO_AUTOEN,
"wl1251", wl);
if (ret < 0) {
wl1251_error("request_irq() failed: %d", ret);
goto disable;
Expand Down

0 comments on commit 5a4d42c

Please sign in to comment.