vaapi_decode: support dynamically frame pool resizing. #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good to me, thanks. |
xuguangxin
force-pushed
the
frame_pool
branch
2 times, most recently
from
a9e9825
to
dd8e0f7
Compare
|
breaks i965 😞 |
|
thanks, I will check it |
|
seems ci will timeout. |
Which cases? I see mostly low PSNR and SSIM. |
|
the CI infrastructure is down at that time, I saw a timeout page. Now it's back online. |
…_DRIVER_QUIRK_FRAME_POOL_RESIZING
…s frame pool resizing Two benifites of this commit: 1. Save memory. If we play an 8k hevc, previous code we allocate 50M * 20(1 + 16 + 3) = 1G memory.16 is a waste for most playback cases. 2. Allow downstream cache more frames. A downstream lookahead encoder will cache some frames. 20 may not enough for it. This commit will fix the following command ffmpeg -hwaccel vaapi -hwaccel_output_format vaapi -i 100frames.264 -vf reverse -an -f null -
|
close. please reopen if you need more review and pre-check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two benefits of this patch set:
1. Save memory. If we play an 8k hevc, previous code we allocate 50M * 20(1 + 16 + 3) = 1G memory. 16 is a waste for most playback cases.
2. Allow downstream cache more frames. A downstream lookahead encoder will cache some frames. 20 may not enough for it.
This patch set will fix the following command
ffmpeg -hwaccel vaapi -hwaccel_output_format vaapi -i 100frames.264 -vf reverse -an -f null -