RFC: Add HEVC Rext decode support for d3d11va/dxva2 on Intel #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyanmisaka
force-pushed
the
dxva-hevc-rext
branch
from
d93d5a8
to
58100bc
Compare
Add support for VUYX, YUYV422, Y210, XV30, P012, Y212, XV36. The added formats work with qsv acceleration and will not have impact on d3d11va acceleration(-hwaccel d3d11va) since so far these formats are still not supported by using d3d11va acceleration. Signed-off-by: Tong Wu <tong1.wu@intel.com>
Add support for VUYX, YUYV422, Y210, XV30, P012, Y212, XV36. The added formats work with qsv acceleration and will not have impact on dxva2 acceleration(-hwaccel dxva2) since so far these formats are still not supported by using dxva2 acceleration. Signed-off-by: Tong Wu <tong1.wu@intel.com>
Picture Parameters DXVA buffer struct for Rext is not specified in DXVA spec. The below structures come from Intel platform DDI definition, so they are currently Intel specific. For Nvidia and AMD platforms supporting HEVC Rext, it is expected the picture param information included in below structures is sufficient for underlying drivers supporting range extension. Signed-off-by: Steve Lhomme <robux4@ycbcr.xyz> Signed-off-by: nyanmisaka <nst799610810@gmail.com>
Signed-off-by: nyanmisaka <nst799610810@gmail.com>
…with DXVA2/D3D11VA Signed-off-by: nyanmisaka <nst799610810@gmail.com>
nyanmisaka
force-pushed
the
dxva-hevc-rext
branch
from
58100bc
to
e21b421
Compare
|
Currently HEVC Rext related GUIDs need support from Microsoft SDK headers. It looks like it's a better idea for us to connect with Microsoft for a new released header with those GUIDs defined. We will push this process, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the HEVC Rext has been commonly supported on Intel IceLake and newer platforms and 4:2:2 has been used in many advanced video recorders, as well as the recently released Chromium has supported Rext on Intel too, I think it is worth to add this in d3d11va/dxva2 to accelerate their playback in third-party players with the help of LavFilters.
The essential patch 3/5 is taken from the VLC player and it works fine for years but it seems that the ffmpeg dev preferred to have Microsoft to release a new header for HEVC Rext.
I have verified this patch locally, including its interop with QSV VPP.
I wonder if you guys can push this series into ffmpeg or work with Microsoft to release a new header for HEVC Rext?