Patches from Erez's branch #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Intel Customised Linux PTP. It is not needed, user can use what ever they want. Replace Intel clone of libptpmgmt with official repository. Signed-off-by: Erez Geva <ErezGeva2@gmail.com>
The 2 structure are shared with both C and C++. 'Event state', 'Event count'. Remove event_state header as it become empty. Signed-off-by: Erez Geva <ErezGeva2@gmail.com>
The brief tag should be used with actual description or with detail tag. Signed-off-by: Erez Geva <ErezGeva2@gmail.com>
Make ClockManager Singleton class. Add constant to parameters and methods. Improve return type and documentation. Convert inline methods to non inline, to improve future ABI. Signed-off-by: Erez Geva <ErezGeva2@gmail.com>
Signed-off-by: Erez Geva <ErezGeva2@gmail.com>
Signed-off-by: Erez Geva <ErezGeva2@gmail.com>
Add ClkMgrSubscription copy method. Remove get and set threshold ID and make threshold ID type hidden property of class. Signed-off-by: Erez Geva <ErezGeva2@gmail.com>
Signed-off-by: Erez Geva <ErezGeva2@gmail.com>
The structure size can increase without degrading backward comparability on client side. Signed-off-by: Erez Geva <ErezGeva2@gmail.com>
These changes improve code readability and maintainability. Signed-off-by: Lai Peter Jun Ann <peter.jun.ann.lai@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Tested with run_clkmgr_test:
2.Tested with run_clkmgr_c_test:
