Track latency of per item eviction/promotion between memory tiers #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guptask
force-pushed
the
tier_eviction_latency
branch
from
6b16096 to
6da0627
Compare
igchor
suggested changes
Jul 28, 2023
guptask
force-pushed
the
tier_eviction_latency
branch
from
6da0627 to
4d5ba92
Compare
igchor
suggested changes
Jul 28, 2023
guptask
force-pushed
the
tier_eviction_latency
branch
from
4d5ba92 to
1086394
Compare
igchor
reviewed
Jul 31, 2023
guptask
force-pushed
the
tier_eviction_latency
branch
from
1086394 to
7c4c6cf
Compare
guptask
commented
Jul 31, 2023
igchor
reviewed
Jul 31, 2023
| util::RollingLatencyTracker rollTracker{ | ||
| (*stats_.classAllocLatency)[tid][pid][cid]}; | ||
|
|
||
| util::RollingLatencyTracker rollTracker{(*stats_.classAllocLatency)[tid][pid][cid]}; |
There was a problem hiding this comment.
I assume this will still track latency for both user and bg allocations? If yes, it would be nice to put some comment regarding that.
There was a problem hiding this comment.
We're not tracking rolling average latency for background threads separately. This feature is not in use anywhere. It was meant to provide a low overhead tracker for profile-driven batch evictions. Profile-driven approach has not been explored since Daniel Obiri worked on it a year back and found it didn't provide any significant improvement. I'm not sure Meta will accept the rolling stats upstream PR - it has not been reviewed yet.
guptask
force-pushed
the
tier_eviction_latency
branch
2 times, most recently
from
ae2f3ec to
8d2c390
Compare
igchor
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is