support autoawq format #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Signed-off-by: yintong-lu <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Signed-off-by: yintong-lu <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: yintong-lu <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
wenhuach21
reviewed
May 24, 2024
wenhuach21
reviewed
May 24, 2024
wenhuach21
reviewed
May 24, 2024
|
don't forget to test the pr in an env without awq lib, all the other functions should be fine |
Signed-off-by: yintong-lu <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: yintong-lu <yintong.lu@intel.com>
for more information, see https://pre-commit.ci
wenhuach21
reviewed
May 24, 2024
wenhuach21
reviewed
May 24, 2024
wenhuach21
reviewed
May 24, 2024
Signed-off-by: yintong-lu <yintong.lu@intel.com>
Signed-off-by: yintong-lu <yintong.lu@intel.com>
Signed-off-by: yintong-lu <yintong.lu@intel.com>
wenhuach21
reviewed
Jun 17, 2024
Signed-off-by: yintong-lu <yintong.lu@intel.com>
wenhuach21
reviewed
Jun 27, 2024
Signed-off-by: yintong-lu <yintong.lu@intel.com>
Signed-off-by: yintong-lu <yintong.lu@intel.com>
Signed-off-by: yintong-lu <yintong.lu@intel.com>
Signed-off-by: yintong-lu <yintong.lu@intel.com>
Signed-off-by: yintong-lu <yintong.lu@intel.com>
Signed-off-by: yintong-lu <yintong.lu@intel.com>
wenhuach21
reviewed
Jul 24, 2024
Signed-off-by: yintong-lu <yintong.lu@intel.com>
Signed-off-by: yintong-lu <yintong.lu@intel.com>
Signed-off-by: yintong-lu <yintong.lu@intel.com>
wenhuach21
reviewed
Jul 30, 2024
| # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| # AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER |
There was a problem hiding this comment.
move all the license claims to the top of the file
wenhuach21
reviewed
Jul 30, 2024
| @@ -150,5 +150,4 @@ def test_autoround_format(self): | |||
| # inputs = tokenizer(text, return_tensors="pt").to(model.device) | |||
| # print(tokenizer.decode(model.generate(**inputs, max_new_tokens=50)[0])) | |||
| # shutil.rmtree("./saved", ignore_errors=True) | |||
There was a problem hiding this comment.
add unittest to export and run generation
There was a problem hiding this comment.
unittest would fail because autoawq is not on the required package list and an error would raise.
There was a problem hiding this comment.
add the ut and skip the test if awq has not been installed, we could test it locally and refine the ut system in the future.
wenhuach21
approved these changes
Jul 30, 2024
wenhuach21
reviewed
Jul 30, 2024
| else: | ||
| qlayer.pack(layer, scale, zero, None) | ||
| qlayer.to(device) | ||
| else: # pragma: no cover |
There was a problem hiding this comment.
remove all the no cover claim, this is not a good way to handle code coverage issue. We could merge the pr even the code coverage is low as long as some important unit test has been added.
Signed-off-by: yintong-lu <yintong.lu@intel.com>
|
Please wait to merge until version 0.3 is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.