Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LGTM to readme #1380

Closed
terriko opened this issue Oct 13, 2021 · 4 comments · Fixed by #1501
Closed

Add LGTM to readme #1380

terriko opened this issue Oct 13, 2021 · 4 comments · Fixed by #1501
Labels
good first issue Good for newcomers hacktoberfest good issue for hacktoberfest participation

Comments

@terriko
Copy link
Contributor

terriko commented Oct 13, 2021

No description provided.

@Molkree
Copy link
Contributor

Molkree commented Oct 22, 2021

Is this issue about adding LGTM.com badges to the Readme or something else? If it is about badges, would you want number of alerts, code quality or both? Here's how they look for anyone interested:
image

@terriko
Copy link
Contributor Author

terriko commented Oct 28, 2021

Yes, this is about adding LGTM.com badges to README.md, to go alongside our other badges.

We were particularly talking about the code quality one in the meeting where I filed this issue, but if the alerts look useful too I don't mind having both. We'll eventually want to have a discussion about streamlining which code quality tools we use, but I think the overhead of adding a couple of badges isn't unreasonable to do to see if we find this one useful.

@terriko terriko added hacktoberfest good issue for hacktoberfest participation good first issue Good for newcomers labels Oct 28, 2021
XDRAGON2002 added a commit to XDRAGON2002/cve-bin-tool that referenced this issue Jan 3, 2022
@XDRAGON2002
chore: added LGTM badges to readme (intel#1380)
fdbbef7
XDRAGON2002 added a commit to XDRAGON2002/cve-bin-tool that referenced this issue Jan 3, 2022
@XDRAGON2002
chore: added LGTM badges to readme (intel#1380)
a477abe
XDRAGON2002 added a commit to XDRAGON2002/cve-bin-tool that referenced this issue Jan 3, 2022
@XDRAGON2002
chore: added LGTM badges to readme (intel#1380)
b03a307
@XDRAGON2002
Copy link
Contributor

I would like to work on this.

@XDRAGON2002 XDRAGON2002 mentioned this issue Jan 3, 2022
Merged
@XDRAGON2002
Copy link
Contributor

Opened PR #1501 that closes this issue.

terriko pushed a commit that referenced this issue Jan 5, 2022
@XDRAGON2002
chore: added LGTM badges to readme (fixes #1380) (#1501)
93c37ff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest good issue for hacktoberfest participation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: added LGTM badges to readme (#1380) XDRAGON2002/cve-bin-tool
3 participants
@terriko @Molkree @XDRAGON2002