fix: TestPackageListParser/test_valid_requirements is broken

[terriko]

Description

The test "test_valid_requirements" in test/test_package_list_parser.py is broken and needs to be updated or replaced with a correct test that covers the same code.

This may have been broken for some time, as an unrelated issue caused the test to not be run at all (see #3631). It's possible that the issue is not in the test code but elsewhere. It's possible that it's just an ordering thing in the array of test data -- you may want to consider replacing the current assert with an assert for each product to help you narrow down the problem.

Note that this is currently set to run only on ubuntu systems. although it's part of something that is ubuntu-specific, this particular piece looks like it could be debugged on any system as long as you remove the skipif section above it.

To reproduce

Run just this test:
pytest -k test_valid_requirements

(If it is showing up as skipped, you will need to enable it in the code yourself.)

Expected case: the test should pass
Actual case: the test fails due to differences in the expected and actual output arrays of product info.

[ayushthe1]

hey @terriko ,can I take up on this one.

[terriko]

@ayushthe1 sure, I'll assign you. What's going wrong wasn't immediately obvious to me at a quick glance, so it may be a bit confusing to fix. Good luck!

[mastersans]

Hey @ayushthe1 are you working on this if not I'll like to continue your work.

[mastersans]

ok so its been 5 days i am working on this.!

[ayushthe1]

Oh sorry @mastersans , this issue fell off my radar.
@terriko Could you please take a look at the PR #3673 and suggest if any further changes are required.

[terriko]

Not sure if the test is still broken, but it is still disabled if anyone wants to look at it.