ci: fix sbom test skipping logic #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was causing more tests to be skipped than intended because of a bad string compare. Signed-off-by: Terri Oda <terri@toybox.ca>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3631 +/- ##
==========================================
+ Coverage 77.79% 80.35% +2.56%
==========================================
Files 777 785 +8
Lines 11680 11853 +173
Branches 1369 1601 +232
==========================================
+ Hits 9086 9525 +439
+ Misses 2178 1915 -263
+ Partials 416 413 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Dec 19, 2023
nedsouza
approved these changes
Dec 20, 2023
nedsouza
approved these changes
Dec 20, 2023
nedsouza
approved these changes
Dec 20, 2023
inosmeet
pushed a commit
to inosmeet/cve-bin-tool
that referenced
this pull request
Feb 16, 2024
* ci: fix sbom test skipping logic This code was causing more tests to be skipped than intended because of a bad string compare. * fix: pre-commit 3.6.0 was a lie * test: disable failing test & add docstrings --------- Signed-off-by: Terri Oda <terri.oda@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was causing more tests to be skipped than intended because of a bad string compare.
fixes #3629