-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: python windows dll pattern tests #4032
Comments
I am working on this. It'd be fun to work on this |
@ranjanmangla1 have fun! Let us know if you get stuck anywhere. |
@terriko sorry for the late response the mapping test is working fine, package test/file test:
, is giving an error about python not being found actually it is creating an empty tar file in condensed_downloads directory, i tried giving an already downloaded file in downloads dir. but still getting test case failed for this one I manually verified the python version in the file using msiextract & got this:
what can be done to solve this issue? |
Hmm, the condensed downloads code I don't think has been changed recently, but the fact that it's making an empty file is suspicious because that implies it's not extracting strings correctly. My first guess would be that it might be because our condensed download code doens't understand msi, but that's really a guess and could be completely off track. |
In #4023, @jananir640 has added a pattern to detect python3 DLLs for windows correctly.
It would be good to have a pair of tests using this new pattern:
https://s3.amazonaws.com/ddagent-windows-stable/datadog-agent-7-latest.amd64.msi
which was the file that originally triggered the bugThis should be doable by a new user, so I'm flagging it as a good first issue. But now that we're not in the middle of gsoc applications (and thus trying to save good first issues for gsoc applicants), anyone should feel free to work on this.
The text was updated successfully, but these errors were encountered: