-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add offline command line option (#1452) #1480
Conversation
Resync repository
Codecov Report
@@ Coverage Diff @@
## main #1480 +/- ##
==========================================
+ Coverage 82.44% 83.82% +1.38%
==========================================
Files 279 279
Lines 5458 5473 +15
Branches 886 888 +2
==========================================
+ Hits 4500 4588 +88
+ Misses 767 698 -69
+ Partials 191 187 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. It makes me wonder if we should be deprecating the two other flags in favour of this one, but I feel like we probably would want to keep them for backwards compatibility even if I suspect most users will just use this instead.
Going to try to re-run CI before merging this, just in case for the 3.10 tests. |
@terriko CI still failing :-( with isort failure.... very strange. Regarding the options, I think they are still useful particulatrly the check for a new version of the tool. This is where it would be very useful to have some usage stats of how the tool is being used and what options are being specified. |
isort failure has been fixed in pypa/setuptools@9c9c91c or we could do one of the workarounds if it still doesn't work |
other pr caused a conflict. I tried to resolve via web interface, so CI is re-running now. |
And yeah, let's get one of the isort workarounds in to CI, probably in a separate PR. |
Good news: isort is happy again! |
No description provided.