Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: find SBOM product vendor (#1477) #1481

Merged
merged 25 commits into from
Dec 27, 2021
Merged

Conversation

anthonyharrison
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2021

Codecov Report

Merging #1481 (40d32cc) into main (1ddae10) will increase coverage by 0.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1481      +/-   ##
==========================================
+ Coverage   82.07%   82.51%   +0.43%     
==========================================
  Files         278      279       +1     
  Lines        5435     5445      +10     
  Branches      882      884       +2     
==========================================
+ Hits         4461     4493      +32     
+ Misses        783      763      -20     
+ Partials      191      189       -2     
Flag Coverage Δ
longtests 82.51% <100.00%> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/sbom_manager/__init__.py 98.24% <100.00%> (+2.79%) ⬆️
cve_bin_tool/version.py 68.42% <0.00%> (-5.27%) ⬇️
cve_bin_tool/package_list_parser.py 71.66% <0.00%> (-0.24%) ⬇️
test/test_cvescanner.py 100.00% <0.00%> (ø)
cve_bin_tool/cvedb.py 82.40% <0.00%> (+1.39%) ⬆️
cve_bin_tool/nvd_api.py 87.75% <0.00%> (+5.10%) ⬆️
cve_bin_tool/cve_scanner.py 84.89% <0.00%> (+8.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ddae10...40d32cc. Read the comment docs.

@terriko
Copy link
Contributor

terriko commented Dec 27, 2021

The CI errors on this one are weird and look like network-related issues in CI:

[INFO] Initializing environment for https://github.com/pycqa/isort.
[INFO] Initializing environment for https://github.com/python/black.
An unexpected error has occurred: CalledProcessError: command: ('/usr/bin/git', 'fetch', 'origin', '--tags')
return code: 128
expected return code: 0
stdout: (none)
stderr:
    error: RPC failed; curl 56 GnuTLS recv error (-54): Error in the pull function.
    error: 2173 bytes of body are still expected
    fetch-pack: unexpected disconnect while reading sideband packet
    fatal: early EOF
    fatal: fetch-pack: invalid index-pack output
    
Check the log at /home/runner/.cache/pre-commit/pre-commit.log

I'm going to go ahead and trigger it to re-run and see if those resolve.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. CI may fail on main due to the windows issue, but I think this is good to merge anyhow.

@terriko terriko merged commit d1cb4db into intel:main Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants