Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Libsrtp checker (#1489) #1500

Merged
merged 6 commits into from
Jan 5, 2022
Merged

Conversation

XDRAGON2002
Copy link
Contributor

Closes #1489

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2022

Codecov Report

Merging #1500 (51accf8) into main (e36bc96) will increase coverage by 1.45%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1500      +/-   ##
==========================================
+ Coverage   82.40%   83.85%   +1.45%     
==========================================
  Files         279      281       +2     
  Lines        5450     5482      +32     
  Branches      885      889       +4     
==========================================
+ Hits         4491     4597     +106     
+ Misses        769      698      -71     
+ Partials      190      187       -3     
Flag Coverage Δ
longtests 83.85% <100.00%> (+1.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.45% <ø> (ø)
cve_bin_tool/checkers/libsrtp.py 100.00% <100.00%> (ø)
test/test_data/libsrtp.py 100.00% <100.00%> (ø)
cve_bin_tool/cli.py 74.07% <0.00%> (-0.55%) ⬇️
cve_bin_tool/package_list_parser.py 71.66% <0.00%> (ø)
test/test_output_engine.py 98.55% <0.00%> (+0.02%) ⬆️
cve_bin_tool/extractor.py 65.21% <0.00%> (+1.24%) ⬆️
cve_bin_tool/version_scanner.py 76.19% <0.00%> (+1.36%) ⬆️
cve_bin_tool/cvedb.py 85.83% <0.00%> (+3.43%) ⬆️
cve_bin_tool/checkers/glibc.py 100.00% <0.00%> (+4.16%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e36bc96...51accf8. Read the comment docs.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the other linux test failures are unrelated (backport fix information wasn't downloading) .

But format_checkers should have given you updated tables in the docs, and you'll need to commit them to the PR as well before it will pass. Can you run that code manually and make sure the docs are updated in the next version of this PR? And if format_checkers is not working, can you mention it here/file a bug? I did some big docs changes and I don't think it should have affected format_checkers, but it might have.

@@ -0,0 +1,23 @@
# Copyright (C) 2021 Intel Corporation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New files should use 2022 instead of 2021.

@XDRAGON2002
Copy link
Contributor Author

Updated year to 2022.

Also upon running format_checkers manually it worked as expected, don't know why it didn't with the pre-commit hook.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! The nvd error looks like the usual transient network problem, so I'm going to go ahead and merge and let it re-run on main.

@terriko terriko merged commit 3c45ac9 into intel:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New checker request: Libsrtp
3 participants