-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added Libsrtp checker (#1489) #1500
Conversation
6ae37dd
to
bcb22cc
Compare
Codecov Report
@@ Coverage Diff @@
## main #1500 +/- ##
==========================================
+ Coverage 82.40% 83.85% +1.45%
==========================================
Files 279 281 +2
Lines 5450 5482 +32
Branches 885 889 +4
==========================================
+ Hits 4491 4597 +106
+ Misses 769 698 -71
+ Partials 190 187 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the other linux test failures are unrelated (backport fix information wasn't downloading) .
But format_checkers should have given you updated tables in the docs, and you'll need to commit them to the PR as well before it will pass. Can you run that code manually and make sure the docs are updated in the next version of this PR? And if format_checkers is not working, can you mention it here/file a bug? I did some big docs changes and I don't think it should have affected format_checkers, but it might have.
cve_bin_tool/checkers/libsrtp.py
Outdated
@@ -0,0 +1,23 @@ | |||
# Copyright (C) 2021 Intel Corporation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New files should use 2022 instead of 2021.
Updated year to 2022. Also upon running format_checkers manually it worked as expected, don't know why it didn't with the pre-commit hook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! The nvd error looks like the usual transient network problem, so I'm going to go ahead and merge and let it re-run on main.
Closes #1489