-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated so it shows the correct versions of Python #1515
Conversation
Update test/README.md so it shows the correct versions of Python
test/README.md
Outdated
If you're using Windows we **strongly** recommend also `pdftotext`. We experienced problems running tests without this. The best approach to do this is through [conda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/windows.html) (click [here](https://anaconda.org/conda-forge/pdftotext) to find out how to install this package with conda). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@terriko isn't it suggested that we install pdftotext
irrelevant of the OS, but recommended to install it via conda for windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @anthonyharrison 's changes have made it so that it will fail gracefully if pdftotext is not installed regardless of platform, so we don't need this message any more. It's out of scope for this pull request anyhow and I'm not sure why it's showing up. Reversion from an earlier version maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you take the pdftotext section out of this PR? It might be easier to revert the file and re-apply your other changes to make it go away.
OK. I have changed the README.md file to the requested changes now :) |
I would honestly remove explicit mentions of Python versions and just say "Our CI currently runs tests on all supported versions of Python under Linux and latest version of Python under Windows." |
Yeah, in a few places we tell people to check CI for supported versions too. But most of this PR is updating install instructions where we can't skip explicit version numbers without making it confusing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough for now. I think if someone wanted to change line 46 to the text recommended by @Molkree , that'd be another valid PR later.
Update test/README.md so it shows the correct versions of Python
Fixes #1510