Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gave output types its own subheading #1516

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Gave output types its own subheading #1516

merged 1 commit into from
Jan 12, 2022

Conversation

DangerChamp
Copy link
Contributor

Gave output types its own subheading in README.md
Fixes #1506

@DangerChamp
Gave output types its own subheading
c223595 
Gave output types its own subheading in README.md
@BreadGenie
Copy link
Contributor

Just a small nitpick. We follow Conventional Commits while creating PRs. You can follow them to make Terri's life a bit easier :P

terriko
terriko approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! As mentioned, it would be great if you can read up on conventional commits for future PRs so you know how to do it. I'll change this one to include "doc: " as a prefix when I do the merge.

@terriko
Copy link
Contributor

terriko commented Jan 12, 2022

Side note: this failed CI because of the NVD rate limiting issue. I've since put a fix into main; if you've got other PRs that are failing you might want to git rebase to origin/main

@terriko terriko merged commit a124bde into intel:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give the output types information its own subheading and table of contents entry in README.md
3 participants
@DangerChamp @BreadGenie @terriko