-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add bandit to pre-commit (fixes #1110) #1523
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1523 +/- ##
==========================================
+ Coverage 79.26% 80.34% +1.07%
==========================================
Files 281 281
Lines 5546 5581 +35
Branches 905 911 +6
==========================================
+ Hits 4396 4484 +88
+ Misses 966 899 -67
- Partials 184 198 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Note to self: need to update the contributor docs in this PR before merging it. |
And docs have been added. ready for review! |
Co-authored-by: Bread Genie <63963181+BreadGenie@users.noreply.github.com>
Thanks for the review @BreadGenie -- I'm going to count this as reviewed enough to merge and get it up. |
Note that because there's a bug about marking things
#nosec
when they span multiple lines, I've disabled the SQL checker which was catching those. (We had some cases where we needed to use a table name from a variable and the like; they're fine and can be verified manually pre-release just in case.)