Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add bandit to pre-commit (fixes #1110) #1523

Merged
merged 6 commits into from
Jan 26, 2022
Merged

Conversation

terriko
Copy link
Contributor

@terriko terriko commented Jan 12, 2022

Note that because there's a bug about marking things #nosec when they span multiple lines, I've disabled the SQL checker which was catching those. (We had some cases where we needed to use a table name from a variable and the like; they're fine and can be verified manually pre-release just in case.)

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #1523 (01602af) into main (277f3b9) will increase coverage by 1.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
+ Coverage   79.26%   80.34%   +1.07%     
==========================================
  Files         281      281              
  Lines        5546     5581      +35     
  Branches      905      911       +6     
==========================================
+ Hits         4396     4484      +88     
+ Misses        966      899      -67     
- Partials      184      198      +14     
Flag Coverage Δ
longtests 80.34% <0.00%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/available_fix/redhat_cve_tracker.py 70.68% <0.00%> (+48.27%) ⬆️
cve_bin_tool/nvd_api.py 86.00% <0.00%> (-1.76%) ⬇️
cve_bin_tool/cli.py 71.42% <0.00%> (-0.34%) ⬇️
cve_bin_tool/cvedb.py 71.94% <0.00%> (ø)
test/test_output_engine.py 98.55% <0.00%> (ø)
cve_bin_tool/checkers/xml2.py 61.36% <0.00%> (ø)
cve_bin_tool/cve_scanner.py 85.10% <0.00%> (+0.21%) ⬆️
test/test_available_fix.py 76.47% <0.00%> (+19.80%) ⬆️
cve_bin_tool/available_fix/__init__.py 82.05% <0.00%> (+23.07%) ⬆️
cve_bin_tool/available_fix/debian_cve_tracker.py 78.00% <0.00%> (+42.58%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 277f3b9...01602af. Read the comment docs.

@terriko
Copy link
Contributor Author

terriko commented Jan 13, 2022

Note to self: need to update the contributor docs in this PR before merging it.

@terriko
Copy link
Contributor Author

terriko commented Jan 13, 2022

And docs have been added. ready for review!

@terriko terriko requested a review from antoniogi January 13, 2022 21:46
@terriko terriko mentioned this pull request Jan 24, 2022
Co-authored-by: Bread Genie <63963181+BreadGenie@users.noreply.github.com>
@terriko
Copy link
Contributor Author

terriko commented Jan 26, 2022

Thanks for the review @BreadGenie -- I'm going to count this as reviewed enough to merge and get it up.

@terriko terriko merged commit d6ade7c into intel:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Bandit into CI
3 participants