fix: set default version for xml2 checker to UNKNOWN (Fixes #1517) #1524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resync repository
chore: update pre-commit config
# Conflicts: # .pre-commit-config.yaml # dev-requirements.txt
…ntel#1517)" This reverts commit 076e16f.
terriko
requested changes
Jan 13, 2022
|
Found the issue - there was a check in xml2 checker which used len() to determine if the version number needed updating. Moved setting of UNKNOWN to the end of the function works now.
|
anthonyharrison
changed the title
anthonyharrison
changed the title
Molkree
reviewed
Jan 25, 2022
Molkree
suggested changes
Jan 25, 2022
anthonyharrison
changed the title
Co-authored-by: Dmitry Volodin <mr.molkree@gmail.com>
|
Looks like my NVD change killed the CI on this one, but it looks like it should work and the xml short tests pass on my machine, so I'm going to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.