feat: extractor support for .pkg and .zst packages #1580
Conversation
|
@terriko @BreadGenie I understand that this is not the complete PR but I wanted to confirm if I'm working in the right direction! |
Codecov Report
@@ Coverage Diff @@
## main #1580 +/- ##
==========================================
- Coverage 81.44% 81.02% -0.43%
==========================================
Files 290 290
Lines 5811 5834 +23
Branches 957 961 +4
==========================================
- Hits 4733 4727 -6
- Misses 856 884 +28
- Partials 222 223 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
It looks like it's working well! (Tried it with openssl)
But do we need 2 approaches for extraction? I think the python implementation works fine and fast since zstandard python package is just an interface for the C library.
|
@BreadGenie how do the extraction functions look now? |
| raise Exception("tar is required to extract .pkg files") | ||
| else: | ||
| stdout, stderr, return_code = await aio_run_command( | ||
| ["tar", "xf", filename, "-C", extraction_path] |
There was a problem hiding this comment.
Can this be replaced by tarfile? If tarfile is a slower approach then let's not do it.
|
@BreadGenie @terriko tarfile seems to be having a problem handling these .pkg files. Should I add 7z support so that the extractor works on windows too? |
fixes #1555