-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove reportlab from default install #1626
Conversation
terriko
commented
Mar 30, 2022
- fixes tool includes reportlab dependency which is flagged by Safety #1459
Copying over from the bug report: The diff in Note that I also reved the version number in here; that was to facilitate some testing against testpypi for package building. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@terriko Looks good. Are there any changes that need to be made to the test suite to demonstrate when PDF support is available or not?
@anthonyharrison Yes, I've been trying to figure out what would be a viable test to add here. Manually, what I did was variations on this:
I also did a bunch of testing with testpypi trying to verify the packaging, but I don't think we can (or should) automate those. I'm going to go ahead and file a separate bug for tests and merge this so I can start prepping a pre-release, but I think a test would be viable it's just a matter of seeing if we can strip it down so we don't have to churn on installing stuff or scan an actual file. Maybe something with mock? |