fix: check return on re.search #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses intel#1639 re.search returns `None` on failure, updating to indicate the version is `UNKNOWN` when this occurs and generating a log message
Codecov Report
@@ Coverage Diff @@
## main #1643 +/- ##
==========================================
- Coverage 78.44% 78.24% -0.21%
==========================================
Files 291 291
Lines 6009 6012 +3
Branches 986 987 +1
==========================================
- Hits 4714 4704 -10
- Misses 1081 1092 +11
- Partials 214 216 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
anthonyharrison
pushed a commit
to anthonyharrison/cve-bin-tool
that referenced
this pull request
May 2, 2022
addresses intel#1639 re.search returns `None` on failure, updating to indicate the version is `UNKNOWN` when this occurs and generating a log message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #1639
re.search returns
Noneon failure, updating to indicate the version isUNKNOWNwhen this occurs and generating a log messageI noted as well that there are other places in the code where this is unchecked, but it doesn't look like they could normally fail, but this should specifically fix #1639.
Checklist
Have I checked on the results from GitHub Actions?
Please feel free to make any recommendations / suggestions for improvement as this is my first PR to your project.