Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improved debug output (fixes #1653) #1654

Merged
merged 48 commits into from
May 3, 2022
Merged

Conversation

anthonyharrison
Copy link
Contributor

No description provided.

anthonyharrison and others added 30 commits May 27, 2020 12:55
@codecov-commenter
Copy link

Codecov Report

Merging #1654 (879471c) into main (61b028b) will decrease coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1654      +/-   ##
==========================================
- Coverage   80.91%   80.76%   -0.16%     
==========================================
  Files         291      291              
  Lines        6027     6031       +4     
  Branches      989      991       +2     
==========================================
- Hits         4877     4871       -6     
- Misses        941      950       +9     
- Partials      209      210       +1     
Flag Coverage Δ
longtests 80.76% <100.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/cvedb.py 85.51% <100.00%> (+0.16%) ⬆️
cve_bin_tool/validator.py 100.00% <100.00%> (ø)
cve_bin_tool/nvd_api.py 75.00% <0.00%> (-9.49%) ⬇️
cve_bin_tool/cli.py 72.72% <0.00%> (+0.43%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I wonder if maybe multiple vendors is something that should be an info message, or does it come up so frequently that it would just be noise?

@terriko terriko merged commit 23baf5e into intel:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants