Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add affected-versions to all formats (#1342) #1667

Merged
merged 23 commits into from
Jun 30, 2022
Merged

feat: add affected-versions to all formats (#1342) #1667

merged 23 commits into from
Jun 30, 2022

Conversation

XDRAGON2002
Copy link
Contributor

Closes #1342

@XDRAGON2002
Updated spelling.yml
ffba885
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
c191f20
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
576871b
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
5707392
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
63981f0
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
ad0032f
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
a38777e
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
db3e815
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
e3d5602
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
eadbc73
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
a23f5c3
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
2b5759a
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
8723ee4
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into main
dd8c8d3
@XDRAGON2002
Merge branch 'main' of https://github.com/intel/cve-bin-tool into iss…
abdaa33 
…ue_1342
@XDRAGON2002
feat: add affected-versions to all formats
a854b62
terriko
terriko requested changes May 24, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some conflicts with the exploited-versions output. Can you resolve them?

@XDRAGON2002
Copy link
Contributor Author

Many tests need to be updated and added for this PR as well as merge conflicts need to be resolved, so converting this to a draft for the time being.

@XDRAGON2002 XDRAGON2002 marked this pull request as draft May 25, 2022 14:15
@XDRAGON2002 XDRAGON2002 marked this pull request as ready for review June 15, 2022 09:20
@terriko
Copy link
Contributor

terriko commented Jun 16, 2022

How's this PR going? I've updated the branch to see if that'll fix the tests, but it wasn't clear to me what state it's in. Is it theoretically ready if we can resolve the tests?

@XDRAGON2002
Copy link
Contributor Author

Yes, the tests are failing for a weird reason which I am trying to resolve, but other than that it's completely done.

terriko
terriko requested changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like test_console_output_depending_reportlab_existence has a place where format_output needs the extra argument.

@XDRAGON2002 XDRAGON2002 requested a review from terriko June 27, 2022 23:14
terriko
terriko approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, it's finally merge time! Thanks for all your work on this one.

@terriko terriko merged commit dfbedfb into intel:main Jun 30, 2022
@Molkree Molkree mentioned this pull request Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add affected-versions to all output formats
2 participants
@XDRAGON2002 @terriko