Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(extractor): added tests for zst and pkg package extractors #1683

Merged
merged 4 commits into from
Jun 16, 2022

Conversation

yashugarg
Copy link
Contributor

@yashugarg yashugarg commented Jun 1, 2022

fixes #1682

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #1683 (cce72e1) into main (fc12dc4) will increase coverage by 0.82%.
The diff coverage is 78.35%.

@@            Coverage Diff             @@
##             main    #1683      +/-   ##
==========================================
+ Coverage   78.55%   79.38%   +0.82%     
==========================================
  Files         299      299              
  Lines        6222     6311      +89     
  Branches     1012     1033      +21     
==========================================
+ Hits         4888     5010     +122     
+ Misses       1116     1083      -33     
  Partials      218      218              
Flag Coverage Δ
longtests 79.38% <78.35%> (+0.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/extractor.py 58.53% <9.09%> (+4.49%) ⬆️
cve_bin_tool/cvedb.py 71.88% <20.00%> (-0.65%) ⬇️
cve_bin_tool/cli.py 69.29% <30.00%> (-1.21%) ⬇️
cve_bin_tool/helper_script.py 85.32% <100.00%> (+26.49%) ⬆️
test/test_extractor.py 100.00% <100.00%> (ø)
test/test_helper_script.py 100.00% <100.00%> (ø)
test/utils.py 94.28% <100.00%> (+0.73%) ⬆️
cve_bin_tool/nvd_api.py 75.20% <0.00%> (-8.80%) ⬇️
cve_bin_tool/util.py 78.37% <0.00%> (+2.70%) ⬆️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@BreadGenie BreadGenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
The PR title can be changed to test(extractor) instead of test: extractor

@yashugarg yashugarg changed the title test: extractor: added tests for zst and pkg package extractors test(extractor): added tests for zst and pkg package extractors Jun 5, 2022
@terriko
Copy link
Contributor

terriko commented Jun 7, 2022

Re-running the windows tests. It might be time to up the limit on windows tests again since these seem to be failing more frequently than they used to. I'll put a tag on this so hopefully I'll come back to it later.

@terriko terriko added the awaiting maintainer Need a maintainer to respond / help out label Jun 7, 2022
@terriko
Copy link
Contributor

terriko commented Jun 16, 2022

Caused a merge conflict with the 7z improvement. I think I've resolved it through the web interface, but we'll see if the black linter disagrees.

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conflict resolved without breaking the linters. hurrah!

Thanks for sorting out the tests! I'll get this merged now.

@terriko terriko merged commit 4000393 into intel:main Jun 16, 2022
@terriko terriko removed the awaiting maintainer Need a maintainer to respond / help out label Jun 16, 2022
@yashugarg yashugarg deleted the test_extractor branch July 5, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: extractor: add tests for zst and pkg package extractors
4 participants