-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(extractor): added tests for zst and pkg package extractors #1683
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1683 +/- ##
==========================================
+ Coverage 78.55% 79.38% +0.82%
==========================================
Files 299 299
Lines 6222 6311 +89
Branches 1012 1033 +21
==========================================
+ Hits 4888 5010 +122
+ Misses 1116 1083 -33
Partials 218 218
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The PR title can be changed to test(extractor)
instead of test: extractor
Re-running the windows tests. It might be time to up the limit on windows tests again since these seem to be failing more frequently than they used to. I'll put a tag on this so hopefully I'll come back to it later. |
Caused a merge conflict with the 7z improvement. I think I've resolved it through the web interface, but we'll see if the black linter disagrees. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conflict resolved without breaking the linters. hurrah!
Thanks for sorting out the tests! I'll get this merged now.
fixes #1682