-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(checker): luajit checker #1705
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1705 +/- ##
==========================================
+ Coverage 78.55% 80.83% +2.27%
==========================================
Files 298 301 +3
Lines 6216 6396 +180
Branches 1011 1050 +39
==========================================
+ Hits 4883 5170 +287
+ Misses 1115 1013 -102
+ Partials 218 213 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like black needs to be run on test/test_data/luajit.py
Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thanks for merging this PR, I didn't updated the documentation as specified in https://github.com/intel/cve-bin-tool/blob/main/cve_bin_tool/checkers/README.md:
However, I don't see any new PR that adds luajit to the documentation ( |
|
@ffontaine Things have changed in #1593. The PR that was talked about in the docs happens when a new checker is added. You don't have to do anything and ignore my previous comment. |
It seems like the GitHub Action that creates the PR failed. |
OK, thanks for your prompt answer, then I assume that I've nothing to do on my side. |
For an unknown reason, the GitHub Action that creates the PR which runs format_checkers.py failed (see #1705) so fix it by running the script manually Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com