Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checker): luajit checker #1705

Merged
merged 1 commit into from
Jul 5, 2022
Merged

feat(checker): luajit checker #1705

merged 1 commit into from
Jul 5, 2022

Conversation

ffontaine
Copy link
Contributor

Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #1705 (abd8364) into main (0f24b06) will increase coverage by 2.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
+ Coverage   78.55%   80.83%   +2.27%     
==========================================
  Files         298      301       +3     
  Lines        6216     6396     +180     
  Branches     1011     1050      +39     
==========================================
+ Hits         4883     5170     +287     
+ Misses       1115     1013     -102     
+ Partials      218      213       -5     
Flag Coverage Δ
longtests 80.83% <100.00%> (+2.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/checkers/__init__.py 95.45% <ø> (ø)
cve_bin_tool/checkers/luajit.py 100.00% <100.00%> (ø)
test/test_data/luajit.py 100.00% <100.00%> (ø)
cve_bin_tool/nvd_api.py 71.20% <0.00%> (-8.80%) ⬇️
cve_bin_tool/output_engine/__init__.py 49.79% <0.00%> (-8.58%) ⬇️
cve_bin_tool/output_engine/util.py 86.95% <0.00%> (-5.36%) ⬇️
test/test_merge.py 100.00% <0.00%> (ø)
test/test_strings.py 100.00% <0.00%> (ø)
test/test_extractor.py 100.00% <0.00%> (ø)
test/test_input_engine.py 100.00% <0.00%> (ø)
... and 22 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like black needs to be run on test/test_data/luajit.py

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
@ffontaine
Copy link
Contributor Author

Done

@ffontaine ffontaine requested a review from terriko July 2, 2022 22:35
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@terriko terriko merged commit 9e205be into intel:main Jul 5, 2022
@ffontaine
Copy link
Contributor Author

Thanks for merging this PR, I didn't updated the documentation as specified in https://github.com/intel/cve-bin-tool/blob/main/cve_bin_tool/checkers/README.md:

You do not need to run format_checkers.py to update the checker table in documentation. A pull request with updated checker table is created automatically when a new checker is merged.

However, I don't see any new PR that adds luajit to the documentation (allow.txt, README.md, MANUAL.md).

@BreadGenie
Copy link
Contributor

BreadGenie commented Jul 6, 2022

@ffontaine it's usually handled by the pre-commit hook if you have it setup on your system. You can create a seperate PR with docs updated after manually running format_checkers.py.

@BreadGenie
Copy link
Contributor

BreadGenie commented Jul 6, 2022

@ffontaine Things have changed in #1593. The PR that was talked about in the docs happens when a new checker is added. You don't have to do anything and ignore my previous comment.

@BreadGenie
Copy link
Contributor

It seems like the GitHub Action that creates the PR failed.

@ffontaine
Copy link
Contributor Author

OK, thanks for your prompt answer, then I assume that I've nothing to do on my side.

terriko pushed a commit that referenced this pull request Jul 12, 2022
For an unknown reason, the GitHub Action that creates the PR which runs
format_checkers.py failed (see
#1705) so fix it by running
the script manually

Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants