Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix file extension in package list scanning #1733

Merged
merged 1 commit into from
Jul 5, 2022
Merged

docs: fix file extension in package list scanning #1733

merged 1 commit into from
Jul 5, 2022

Conversation

b31ngd3v
Copy link
Contributor

@b31ngd3v b31ngd3v commented Jul 1, 2022

faced this error while i was following instructions from the readme

image

@codecov-commenter
Copy link

Codecov Report

Merging #1733 (a0df3ee) into main (82ce324) will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
- Coverage   80.20%   80.05%   -0.16%     
==========================================
  Files         300      300              
  Lines        6427     6427              
  Branches     1050     1050              
==========================================
- Hits         5155     5145      -10     
- Misses       1054     1063       +9     
- Partials      218      219       +1     
Flag Coverage Δ
longtests 80.05% <ø> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/nvd_api.py 75.20% <0.00%> (-8.80%) ⬇️
cve_bin_tool/cli.py 69.29% <0.00%> (+0.39%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

This makes me wonder if we should actually be requiring the .txt extension: we've got the technical ability to check the file type and the extension is only really for human convenience here. But human convenience is important too so there's no harm in it working the way it does. Either way, it's important that the documentation match the actual behaviour, so thank you for this update!

@terriko terriko merged commit 8939d22 into intel:main Jul 5, 2022
@b31ngd3v b31ngd3v deleted the docs branch July 5, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants