Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide multiple output formats for a single scan (#1724) #1740

Merged
merged 15 commits into from
Jul 11, 2022
Merged

feat: provide multiple output formats for a single scan (#1724) #1740

merged 15 commits into from
Jul 11, 2022

Conversation

b31ngd3v
Copy link
Contributor

@b31ngd3v b31ngd3v commented Jul 3, 2022

closes #1724

@b31ngd3v b31ngd3v marked this pull request as ready for review July 3, 2022 19:54
@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2022

Codecov Report

Merging #1740 (692db20) into main (fe2d5d9) will decrease coverage by 0.79%.
The diff coverage is 78.43%.

@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
- Coverage   86.33%   85.54%   -0.80%     
==========================================
  Files         308      308              
  Lines        6615     6653      +38     
  Branches     1071     1080       +9     
==========================================
- Hits         5711     5691      -20     
- Misses        672      724      +52     
- Partials      232      238       +6     
Flag Coverage Δ
longtests 85.54% <78.43%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/output_engine/__init__.py 71.42% <70.00%> (+0.40%) ⬆️
cve_bin_tool/cli.py 72.51% <72.72%> (-0.14%) ⬇️
test/test_output_engine.py 96.92% <73.68%> (-1.95%) ⬇️
cve_bin_tool/output_engine/util.py 88.15% <100.00%> (+1.20%) ⬆️
test/test_cli.py 88.47% <100.00%> (-0.38%) ⬇️
test/test_source_nvd.py 60.71% <0.00%> (-39.29%) ⬇️
test/test_cvedb.py 65.21% <0.00%> (-34.79%) ⬇️
test/test_available_fix.py 76.47% <0.00%> (-23.53%) ⬇️
cve_bin_tool/available_fix/redhat_cve_tracker.py 71.42% <0.00%> (-8.93%) ⬇️
cve_bin_tool/nvd_api.py 75.20% <0.00%> (-8.80%) ⬇️
... and 4 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love the way you've handled the file extensions. I do wonder if that might need some more documentation so people know it's going to happen if they choose a single name, but that can be a separate PR.

@terriko terriko merged commit 6436e06 into intel:main Jul 11, 2022
@b31ngd3v b31ngd3v deleted the 1724 branch July 11, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Providing multiple output formats for a single scan
4 participants